Re: Minimal logical decoding on standbys

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minimal logical decoding on standbys
Date: 2023-02-07 10:36:48
Message-ID: 04c0c56b-2a82-308d-9419-9ddf79ea01dc@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 1/11/23 4:23 PM, Drouvot, Bertrand wrote:
> Hi,
>
> On 1/11/23 8:32 AM, Bharath Rupireddy wrote:
>> On Tue, Jan 10, 2023 at 2:03 PM Drouvot, Bertrand
>> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>>
>>> Please find attached, V37 taking care of:
>>
>> Thanks. I started to digest the design specified in the commit message
>> and these patches.
>
> Thanks for looking at it!
>
>> Here are some quick comments:
>>
>> 1. Does logical decoding on standby work without any issues if the
>> standby is set for cascading replication?
>>
>
> Without "any issues" is hard to guarantee ;-) But according to my tests:
>
> Primary -> Standby1 with or without logical replication slot -> Standby2 with or without logical replication slot
>
> works as expected (and also with cascading promotion).
> We can add some TAP tests in 0004 though.

Cascading standby tests have been added in V48 attached.

It does test that:

- a sql logical decoding session on the cascading standby get expected output before/after the standby promotion
- a pg_recvlogical logical decoding session on the cascading standby (started before the standby promotion) get expected output before/after the standby promotion

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v48-0006-Doc-changes-describing-details-about-logical-dec.patch text/plain 2.1 KB
v48-0005-New-TAP-test-for-logical-decoding-on-standby.patch text/plain 29.3 KB
v48-0004-Fixing-Walsender-corner-case-with-logical-decodi.patch text/plain 7.7 KB
v48-0003-Allow-logical-decoding-on-standby.patch text/plain 11.8 KB
v48-0002-Handle-logical-slot-conflicts-on-standby.patch text/plain 37.0 KB
v48-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch text/plain 76.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2023-02-07 10:38:20 Re: Pluggable toaster
Previous Message Laurenz Albe 2023-02-07 10:29:50 Re: Too coarse predicate locks granularity for B+ tree indexes