Re: Question about InvalidatePossiblyObsoleteSlot()

From: "suyu(dot)cmj" <mengjuan(dot)cmj(at)alibaba-inc(dot)com>
To: "bertranddrouvot(dot)pg" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: "bharath(dot)rupireddyforpostgres" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "amit(dot)kapila16" <amit(dot)kapila16(at)gmail(dot)com>, "michael" <michael(at)paquier(dot)xyz>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Question about InvalidatePossiblyObsoleteSlot()
Date: 2025-10-13 15:03:02
Message-ID: 043df53e-6f11-4d6c-a178-04f4f8b2e742.mengjuan.cmj@alibaba-inc.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Thanks for your detailed reply.
> I think that we could get rid of the initial_restart_lsn and just use
> s->data.restart_lsn here (while keeping initial xmin ones to preserve the
> intent of 818fefd8fd4 for those).
I agree with your proposed change.
> Your concern is only about the restart_lsn, right? (asking because I don't think
> it's safe not to rely on the initial_* for the xmin ones, see [1]).
My primary concern is indeed the restart_lsn issue, and thanks again for the clear explanation.
Best regards,
suyu.cmj

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2025-10-13 15:16:33 Re: Add notification on BEGIN ATOMIC SQL functions using temp relations
Previous Message Andrew Dunstan 2025-10-13 14:58:30 Re: add function argument name to substring and substr