Re: Reorganize GUC structs

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reorganize GUC structs
Date: 2025-10-15 12:46:55
Message-ID: 043d2aa7-6ad9-4833-9b63-15b45b68ccee@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.10.25 13:39, Álvaro Herrera wrote:
> I agree that keeping the guc_parameters.dat file alphabetically sorted
> by default would keep the maintenance cost lowest, because we won't have
> to make any subjective decisions for new entries. However, automatically
> generating the .sample file sounds impractical, considering the
> free-form comments that we currently have there.

Yes, I'm not sure if it's practical in the fullest extent. But there
were at various points discussions about alternative layouts and
contents for postgresql.conf.sample, with a lot of opinions. With this
new framework, I think it might be interesting to experiment. Which is
why I mentioned it.

> I think instead of that mess, maybe we can simply keep the sample file
> as-is, cross-check that a line for each non-hidden GUC variable exists,
> and perhaps that the commented-out default value matches the data file.

Those would certainly be reasonable near-term steps.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2025-10-15 12:48:29 Re: Implement waiting for wal lsn replay: reloaded
Previous Message Peter Eisentraut 2025-10-15 12:37:06 Re: Add log_autovacuum_{vacuum|analyze}_min_duration