| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, vignesh C <vignesh21(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vik Fearing <vik(at)postgresfriends(dot)org> |
| Subject: | Re: [PATCH] Add CANONICAL option to xmlserialize |
| Date: | 2026-03-30 09:58:59 |
| Message-ID: | 042a478b-4927-4683-b80c-79e6f1a2f4bc@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andrew
On 30/03/2026 11:44, Andrew Dunstan wrote:
> Here's a very minor tidy up:
>
> - Split Datum xmlcanonicalize(PG_FUNCTION_ARGS) across two lines
> - Fixed variable declaration alignment
> - Replaced 11-line verbose comment with a single-line /* Canonicalize
> the entire document using C14N 1.1 */
> - Moved #include <libxml/c14n.h> to alphabetical position
> - Removed unnecessary if (doc) / if (xmlbuf) guards on the success-path
> cleanup
> - Added spaces after casts: (xmlDocPtr) doc, (xmlChar *) xmlbuf,
> (xmlChar **) &xmlbuf
>
> I note that your function returns xml, whereas Tom's suggestion was for
> a function returning text. I don't think there was any discussion on the
> point.
Thanks for the code review!
In your v22, I can't find the changes you mentioned. Is it possible that
the wrong file was attached, or were these changes intended for v23?
Best, Jim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-03-30 10:20:47 | RE: Parallel Apply |
| Previous Message | Andrew Dunstan | 2026-03-30 09:44:33 | Re: [PATCH] Add CANONICAL option to xmlserialize |