| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org>, Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | david(dot)g(dot)johnston(at)gmail(dot)com, jacob(dot)champion(at)enterprisedb(dot)com, er(at)xs4all(dot)nl, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Row pattern recognition |
| Date: | 2025-11-25 06:16:10 |
| Message-ID: | 04165F0A-5347-4C98-B794-7E65FD1DDD86@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 24, 2025, at 08:59, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> I will proceed 0007 tomorrow.
I just finished reviewing 0007 and 0008. This patch set really demonstrates the full lifecycle of adding a SQL feature, from changing the syntax in gram.y all the way down to the executor, including tests and docs. I learned a lot from it. Thanks!
23 - 0007
As you mentioned earlier, pattern regular expression support *, + and ?, but I don’t see ? is tested.
24 - 0007
I don’t see negative tests for unsupported quantifiers, like PATTERN (A+?).
25 - 0007
```
+-- basic test with none greedy pattern
```
Typo: “none greedy” -> non-greedy
No comment for 0008.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2025-11-25 06:37:32 | Re: pg_waldump: support decoding of WAL inside tarfile |
| Previous Message | Maxim Orlov | 2025-11-25 06:12:16 | Re: Add 64-bit XIDs into PostgreSQL 15 |