Re: Reverse engineered Column definition incorrect

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>, "Donald Fraser" <demolish(at)cwgsy(dot)net>
Cc: "[pgADMIN]" <pgadmin-support(at)postgresql(dot)org>
Subject: Re: Reverse engineered Column definition incorrect
Date: 2003-10-03 07:09:49
Message-ID: 03AF4E498C591348A42FC93DEA9661B844B73D@mail.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Hi Andreas,

Did you get it on both branches (& both changelogs)?

Regards, Dave.

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de]
> Sent: 02 October 2003 19:17
> To: Donald Fraser
> Cc: [pgADMIN]
> Subject: Re: [pgadmin-support] Reverse engineered Column
> definition incorrect
>
>
> Donald Fraser wrote:
>
> > The reverse engineered code for column definitions if incorrect for
> > DEFAULT values.
> > I create table such as:
> >
> > REATE TABLE public.tbl_bkgndata
> > (
> > id int4 NOT NULL DEFAULT nextval('tbl_bkgndata_id_seq'::text),
> > ) WITHOUT OIDS;
> >
> > Reverse engineered column definition is:
> >
> > ALTER TABLE public.tbl_bkgndata ADD COLUMN id int4;
> > ALTER TABLE public.tbl_bkgndata ALTER COLUMN id SET STORAGE PLAIN;
> > ALTER TABLE public.tbl_bkgndata ALTER COLUMN id SET NOT NULL; ALTER
> > TABLE public.tbl_bkgndata ALTER COLUMN id DEFAULT
> > nextval('tbl_bkgndata_id_seq'::text);
> >
> > Last row should read:
> > ALTER TABLE public.tbl_bkgndata ALTER COLUMN id SET DEFAULT
> > nextval('tbl_bkgndata_id_seq'::text);
> >
> > That is the key word SET is missing.
>
>
> Fixed in cvs, thanks for reporting.
>
> Regards,
> Andreas
>
>
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so
> that your
> message can get through to the mailing list cleanly
>

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2003-10-03 07:50:34 Re: Default value for char/varchar columns is not quoted automaticaly
Previous Message Oldrich Dlouhy 2003-10-03 06:04:24 Default value for char/varchar columns is not quoted automaticaly