On 28.02.23 07:15, Bharath Rupireddy wrote:
>> Going through the remaining report_invalid_record() calls I then
>> adjusted the use of "invalid" vs. "incorrect" in one case. The message
>> "record with invalid length" makes it sound like the length was
>> something like -5, but really we know what the length should be and what
>> we got wasn't it, so "incorrect" sounded better and is also used in
>> other error messages in that file.
> I have no strong opinion about this change. We seem to be using
> "invalid length" and "incorrect length" interchangeably [1] without
> distinguishing between "invalid" if length is < 0 and "incorrect" if
> length >= 0 and not something we're expecting.
Right, this isn't handled very consistently. I did a pass across all
"{invalid|incorrect|wrong} {length|size}" messages and tried to make
them more precise by adding more detail and using the appropriate word.
What do you think about the attached patch?