Re: logtape.c stats don't account for unused "prefetched" block numbers

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logtape.c stats don't account for unused "prefetched" block numbers
Date: 2020-09-08 17:27:06
Message-ID: 0383d21d58c6fd7d2426d7730c50c6743a5ba303.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 2020-09-05 at 12:03 -0700, Peter Geoghegan wrote:
> We should totally disable the preallocation stuff for external sorts
> in any case. External sorts are naturally characterized by relatively
> large, distinct batching of reads and writes -- preallocation cannot
> help.

Patch attached to disable preallocation for Sort.

I'm still looking into the other concerns.

Regards,
Jeff Davis

Attachment Content-Type Size
sort-no-prealloc.patch text/x-patch 5.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-09-08 17:27:50 Re: PROC_IN_ANALYZE stillborn 13 years ago
Previous Message James Coleman 2020-09-08 17:25:21 Re: [DOC] Document concurrent index builds waiting on each other