Re: pg_basebackup: Correct type of WalSegSz

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup: Correct type of WalSegSz
Date: 2023-03-31 08:31:04
Message-ID: 033DFBE7-694D-4C35-8146-8FBB64F0673F@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 30 Mar 2023, at 08:24, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> The pg_basebackup code has WalSegSz as uint32, whereas the rest of the code has it as int. This seems confusing, and using the extra range wouldn't actually work. This was in the original commit (fc49e24fa6), but I suppose it was an oversight.

LGTM, it indeed seems to be an accidental oversight.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-03-31 09:14:20 Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert
Previous Message Greg Stark 2023-03-31 07:59:49 Re: Experiments with Postgres and SSL