| From: | Adrien NAYRAT <adrien(dot)nayrat(at)anayrat(dot)info> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-30 08:46:57 |
| Message-ID: | 031c66cb-95f4-fb31-3676-023a0f1d438d@anayrat.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/18 10:48 PM, Alvaro Herrera wrote:
> Thanks! I pushed this with two changes -- one was to reword the docs a
> bit more, and the other was to compute in_sample only if it's going to
> be used (when exceeded is true). I hope this won't upset any compilers ...
Thanks!
>
> I wonder if there's any sensible way to verify the behavior in an
> automated fashion. Who know what marvels we'd discover about the
> reliability/uniformity of random() across platforms.
>
Yes, I also wondered how to add tests.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrien NAYRAT | 2018-11-30 08:51:58 | Re: New GUC to sample log queries |
| Previous Message | Kyotaro HORIGUCHI | 2018-11-30 08:30:23 | Re: pg_config wrongly marked as not parallel safe? |