Re: BUG #17212: pg_amcheck fails on checking temporary relations

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #17212: pg_amcheck fails on checking temporary relations
Date: 2021-10-14 21:06:00
Message-ID: 02C6345B-D186-4F88-A976-A2CD1051CB93@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> On Oct 14, 2021, at 1:50 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> Bowerbird is having similar issues, so I don't think this is just a
> transient.

The pg_amcheck patch Peter committed for me adds a new test, src/bin/pg_amcheck/t/006_bad_targets.pl, which creates two PostgresNode objects (a primary and a standby) and uses PostgresNode::background_psql(). It doesn't bother to "finish" the returned harness, which may be the cause of an installation hanging around long enough to be in the way when another test tries to start.

Assuming this is right, the fix is just one line. Thoughts?


Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2021-10-14 21:09:23 Re: BUG #17212: pg_amcheck fails on checking temporary relations
Previous Message Andrew Dunstan 2021-10-14 20:50:51 Re: BUG #17212: pg_amcheck fails on checking temporary relations

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-10-14 21:09:23 Re: BUG #17212: pg_amcheck fails on checking temporary relations
Previous Message Gilles Darold 2021-10-14 21:03:23 Re: [PATCH] Proposal for HIDDEN/INVISIBLE column