IndexTupleDSize macro seems redundant

From: Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: IndexTupleDSize macro seems redundant
Date: 2017-11-20 15:31:17
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

While I was looking through the indexes code I got confused by couple of
macros - IndexTupleSize() and IndexTupleDSize() - which seem to do the
same thing with only difference that the first one takes pointer as an
argument while the second one takes struct. And in most cases
IndexTupleDSize() is used with dereferencing of index tuple where
IndexTupleSize() would suit perfectly. Is there a particular reason to
have them both? I've made a patch that removes IndexTupleDSize macro.
All the tests have passed.

Ildar Musin

Attachment Content-Type Size
IndexTupleDSize.patch text/x-patch 5.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Евгений Шишкин 2017-11-20 15:43:38 Re: [HACKERS] Custom compression methods
Previous Message Tomas Vondra 2017-11-20 15:29:11 Re: [HACKERS] Custom compression methods