Re: [COMMITTERS] pgsql: pg_test_timing: Add NLS

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Carlos Chapi <carlos(dot)chapi(at)2ndquadrant(dot)com>
Subject: Re: [COMMITTERS] pgsql: pg_test_timing: Add NLS
Date: 2017-08-26 19:22:16
Message-ID: 025d3ec6-ffa4-916b-f944-4a6acd90523e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 7/6/17 14:56, Alvaro Herrera wrote:
> We (well, Carlos Chapi, who's doing the translation work now) just
> noticed that this has a bug in this line
>
> + printf("%6s %10s %10s\n", _("< us"), _("% of total"), _("count"));
>
> _() marks the strings with the c-string flag, which means that the
> %-specifiers are checked by gettext, but the % in the third literal is
> not a printf specifier. So there's no correct way to write the
> translation. We need to use a different xgettext trigger there, one
> that doesn't set c-format, but I don't know what.

I have fixed this.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-08-26 20:50:28 pgsql: Doc: update v10 release notes through today.
Previous Message Tom Lane 2017-08-26 19:19:46 pgsql: First-draft release notes for 9.6.5.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-26 19:31:12 Back-branch release notes up for review
Previous Message Tom Lane 2017-08-26 19:07:48 Re: Variable substitution in psql backtick expansion