Re: Optimize LISTEN/NOTIFY

From: "Joel Jacobson" <joel(at)compiler(dot)org>
To: "Alexander Lakhin" <exclusion(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Optimize LISTEN/NOTIFY
Date: 2026-05-20 11:47:09
Message-ID: 025766ac-78da-4b0c-a50f-d2d13d2fdad1@app.fastmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 18, 2026, at 21:00, Alexander Lakhin wrote:
> While browsing through new inconsistencies and typos, I came across one
> which I'm not sure what to do with. Could you help, please?
>
> async-notify.spec contains:
> # Check ChannelHashAddListener array growth.
> permutation listenc llisten l2listen l3listen lslisten
>
> But as far as I can see, ChannelHashAddListener() was eliminated in
> 0002-optimize_listen_notify-v13.patch upthread [1]:
>
>> > Or thinking a little bigger: why are we maintaining the set of
>> > channels-listened-to both as a list and a hash? Could we remove
>> > the list form?
>> Yes, it was indeed possible to remove the list form.
>>
>
> So, maybe the comment or perhaps even the test case should be changed/
> removed?

Yes, that test is a leftover from a previous patch version.
I'll post a patch to remove it in a separate thread.

Thanks for spotting.

/Joel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2026-05-20 11:50:06 [PATCH] Remove obsolete LISTEN array growth isolation test
Previous Message Alexander Korotkov 2026-05-20 11:46:30 Re: Fix SPLIT PARTITION bound-overlap bug and other improvements