byteain bug(?)

From: "Joe Conway" <joseph(dot)conway(at)home(dot)com>
To: <pgsql-hackers(at)postgresql(dot)org>
Subject: byteain bug(?)
Date: 2001-09-07 03:11:32
Message-ID: 01d601c1374a$cbf47df0$0705a8c0@jecw2k1
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I just noticed some unexpected behavior from byteain:

test=# select '\\009'::bytea;
?column?
----------
\011
(1 row)

test=# select '\\444'::bytea;
?column?
----------
$
(1 row)

test=# select '\\999'::bytea;
?column?
----------
\221
(1 row)

The reason is the following code in byteain:

else if (!isdigit((unsigned char) *tp++) ||
!isdigit((unsigned char) *tp++) ||
!isdigit((unsigned char) *tp++))
elog(ERROR, "Bad input string for type bytea");

It checks for a '\' followed by three digits, but does not attempt to
enforce that the three digits actually produce a valid octal number. Anyone
object to me fixing this?

-- Joe

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2001-09-07 03:32:12 pgsql/src/backend/utils/mb encnames.c win1251. ...
Previous Message Tom Lane 2001-09-07 02:40:42 Re: FTI contrib