| From: | "Joe Conway" <joseph(dot)conway(at)home(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: bytea_ops |
| Date: | 2001-08-12 06:27:24 |
| Message-ID: | 01c601c122f7$d9fd57d0$0705a8c0@jecw2k1 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Here's a new patch.
> Looks like you missed one VarChar -> bytea.
Fixed.
> I think it's better style to code stuff like this as
>
> PG_RETURN_BOOL((cmp < 0) || ((cmp == 0) && (len1 < len2)));
Done.
> The biggie is that you missed adding support for bytea to scalarltsel,
> which puts a severe crimp on the optimizer's ability to make any
> intelligent decisions about using your index.
Hopefully done correctly ;-)
-- Joe
| Attachment | Content-Type | Size |
|---|---|---|
| bytea_ops_r01.diff | application/octet-stream | 13.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Lance Taylor | 2001-08-12 06:27:28 | Re: Re: [PATCHES] Select parser at runtime |
| Previous Message | Bruce Momjian | 2001-08-12 04:25:28 | Re: Re: [PATCHES] Select parser at runtime |