| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change some Datum to void * for opaque pass-through pointer |
| Date: | 2025-12-28 13:40:03 |
| Message-ID: | 01a3e7cf-37a5-4599-8256-e88d62832299@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.12.25 16:07, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> Here, Datum was used to pass around an opaque pointer between a group of
>> functions. But one might as well use void * for that; the use of Datum
>> doesn't achieve anything here and is just distracting.
>
> We have some APIs where Datum is used to be agnostic about whether
> a pointer or an integer is being passed through. on_shmem_exit()
> callers make use of both cases, for example.
Agreed, those are different situations.
> These tsearch functions don't need that, and they aren't adjacent
> to places using such an API, so I'm fine with this patch as written.
Ok, committed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-12-28 13:55:04 | Re: Get rid of "Section.N.N.N" on DOCs |
| Previous Message | Henson Choi | 2025-12-28 13:31:57 | Re: [PATCH] Add pg_current_vxact_id() function to expose virtual transaction IDs |