Re: Proposal: pg_confcheck - syntactic & semantic validation of postgresql configuration files

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amir Rohan <amir(dot)rohan(at)zoho(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hacker mailing list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: pg_confcheck - syntactic & semantic validation of postgresql configuration files
Date: 2015-10-14 17:50:27
Message-ID: 01C9E007-56C3-4C48-997A-9C7493A41E27@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On October 14, 2015 7:45:53 PM GMT+02:00, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>Amir Rohan wrote:
>
>> it does fail the "dependent options" test:
>> $ postgres -C "archive_mode"
>> on
>> $ postgres -C wal_level
>> minimal
>>
>> no errors, great, let's try it:
>> $ pg_ctl restart
>>
>> FATAL: WAL archival cannot be enabled when wal_level is "minimal"
>
>This complaint could be fixed we had a --check-config that runs the
>check hook for every variable, I think.

The problem is that this, and some others, invariant is checked outside the GUC framework. Which we should probably change, which IIRC will require some new infrastructure.

Andres

---
Please excuse brevity and formatting - I am writing this on my mobile phone.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shay Rojansky 2015-10-14 17:52:36 Re: Allow ssl_renegotiation_limit in PG 9.5
Previous Message Alvaro Herrera 2015-10-14 17:45:53 Re: Proposal: pg_confcheck - syntactic & semantic validation of postgresql configuration files