Re: BUG #4186: set lc_messages does not work

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Thomas H(dot)" <me(at)alternize(dot)com>, <pgsql-bugs(at)postgresql(dot)org>, "Gevik Babakhani" <pgdev(at)xs4all(dot)nl>
Subject: Re: BUG #4186: set lc_messages does not work
Date: 2008-08-05 15:15:35
Message-ID: 019701c8f70e$1c8fd450$0c01a8c0@IBMC9A0F63B40D
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi Magnus.

I have tried with Inoue-san, investigation of this problem, and adjustment.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/pg8.3.3-to_char_gettext_format.png
Native-strftime was proposed by Tom-san. It corrects(LC_TIME) from 8.3.3.(LC_MESSAGES)
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/pg_locale_patch
It has not resulted in the still final conclusion.
However, Possibly this may be the optimal one.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/wcsftimeck.c
I am creating the proposal of patch with Inoue-san.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Magnus Hagander" <magnus(at)hagander(dot)net>

> Bruce Momjian wrote:
>> Tom Lane wrote:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> Thomas H. wrote:
>>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>> pg always picks the os' language and ignores the lc_message value.
>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>> work for you in previous versions?
>>> Maybe we were using a different build of gettext in the previous
>>> releases, one that didn't look at the same info as the current code?
>>>
>>> Anyway the patch mentioned at the start of the thread
>>> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>>> purports to fix this. It doesn't seem to have gotten reviewed
>>> though.
>>
>> Agreed. Magnus, someone, can we get feedback on the patch at this URL?
>>
>> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>
> IIRC, there was further work to be done on the patch before it was to be
> applied, and we held off the review until then.
>
> Gevik - can you comment on this? Where are we, what needs ot be done still?
>
> //Magnus
>
>
> --
> Sent via pgsql-bugs mailing list (pgsql-bugs(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-bugs

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2008-08-05 17:07:11 Hmm, nodeUnique doesn't really support backwards scan too well
Previous Message Magnus Hagander 2008-08-05 14:53:56 Re: BUG #4186: set lc_messages does not work

Browse pgsql-hackers by date

  From Date Subject
Next Message Asko Oja 2008-08-05 15:35:26 Re: Status of DISTINCT-by-hashing work
Previous Message Tom Lane 2008-08-05 15:09:34 Re: small improvement in buffread common