Re: [HACKERS] [PATCH] kNN for SP-GiST

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] kNN for SP-GiST
Date: 2018-07-09 17:47:04
Message-ID: 01432E05-D1AD-4D80-A7B4-149A299E906B@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

> 4 июля 2018 г., в 3:21, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> написал(а):
> Attached 5th version of the patches, where minor refactoring of distance
> handling was done (see below).
>

I'm reviewing this patch. Currently I'm trying to understand sp-gist scan deeeper, but as for now have some small notices.

Following directives can be omitted:
#include "lib/rbtree.h"
#include "storage/relfilenode.h"

This message is not noly GiST related, is it?
elog(ERROR, "GiST operator family's FOR ORDER BY operator must return float8 or float4 if the distance function is lossy");

Some small typos:
usefull -> useful
nearest-neighbour -> nearest-neighbor (or do we use e.g. "colour"?)

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-07-09 18:24:09 Re: How can we submit code patches that implement our (pending) patents?
Previous Message Tom Lane 2018-07-09 17:41:59 Re: [PATCH] btree_gist: fix union implementation for variable length columns