Re: Commit Timestamp and LSN Inversion issue

From: Jan Wieck <jan(at)wi3ck(dot)info>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>
Subject: Re: Commit Timestamp and LSN Inversion issue
Date: 2024-11-12 13:51:49
Message-ID: 00f7cfb2-e3a6-4bd7-b19c-fd75d3838049@wi3ck.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/11/24 23:21, Amit Kapila wrote:
> As the inversion issue can mainly hamper logical replication-based
> solutions we can do any of this additional work under spinlock only
> when the current record is a commit record (which the currently
> proposed patch is already doing) and "wal_level = logical" and also
> can have another option at the subscription level to enable this new
> code path. I am not sure what is best but just sharing the ideas here.

It can indeed be reduced to one extra *unlikely* if test only for commit
records and only when WAL level is "logical". Without those two being
true there would be zero impact on ReserveXLogInsertLocation().

It is not possible to do something on the subscription level because it
affects global behavior of all backends.

Best Regards, Jan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-11-12 13:55:37 Re: Commit Timestamp and LSN Inversion issue
Previous Message Tomas Vondra 2024-11-12 13:48:28 Re: Parametrization minimum password lenght