Re: Bug in canonicalize_path()

From: "uniware" <uniware(at)zedware(dot)org>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Bug in canonicalize_path()
Date: 2005-08-12 02:42:05
Message-ID: 00b101c59ee7$77565df0$1504a8c0@wlzhang
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


----- Original Message -----
From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "William ZHANG" <uniware(at)zedware(dot)org>; <pgsql-patches(at)postgresql(dot)org>
Sent: Friday, August 12, 2005 10:31 AM
Subject: Re: [PATCHES] Bug in canonicalize_path()

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Yep, it is a bug on 8.0.X. Are you suggesting a backpatch? We can do
> > it. Any objections?
>
> I think he's suggesting that we depend on GetFullPathName(), which seems
> a bit pointless considering we have to write the code anyway for other
> platforms.

If it must be fixed, I think we can learn sth. from GetFullPathName().
Since we can not rely on this function on other platforms, we should
write it from scratch.

> I didn't much like the patch as-is; we should think a little harder
> about fixing the logic properly.
>
> regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-08-12 02:49:16 Re: Bug in canonicalize_path()
Previous Message Bruce Momjian 2005-08-12 02:39:30 Re: Bug in canonicalize_path()