Re: Do we really want to migrate plproxy and citext intoPG core distribution?

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, "Asko Oja" <ascoja(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Hannu Krosing" <hannu(at)krosing(dot)net>, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Do we really want to migrate plproxy and citext intoPG core distribution?
Date: 2008-07-28 15:31:42
Message-ID: 00ad01c8f0c7$09e50020$0c01a8c0@IBMC9A0F63B40D
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Marko-san.

Great thanks!!
Please correct one mistake of mine...sorry.
This patch solved problem of win32.:-)

Regards,
Hiroshi Saito

----- Original Message -----
From: "Marko Kreen" <markokr(at)gmail(dot)com>

> On 7/28/08, Marko Kreen <markokr(at)gmail(dot)com> wrote:
>> On 7/25/08, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> wrote:
>> > I tackled with hope temporarily. It seems that some adjustment is still
>> > required.
>> > http://winpg.jp/~saito/pg_work/plproxy/
>> > However, windows user desires to use. Of course, it is also me.
>> > Regards,
>> > Hiroshi Saito
>>
>> Thanks, I applied the patch to CVS, with minor changes:
>> - Use HAVE_SYS_SELECT_H instead of WIN32 for <sys/select.h>
>> - Do SHLIB_LINK += instead of separate var.
>>
>> Could you please test the attached patch or CVS HEAD,
>> whether everything works fine now?
>
> One more change - I replaced __attribute__((dllimport)) with PGDLLIMPORT,
> which seems more standard.
>
> --
> marko
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

Attachment Content-Type Size
Makefile_patch application/octet-stream 619 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2008-07-28 15:51:10 Re: Do we really want to migrate plproxy and citext intoPG core distribution?
Previous Message Andrew Gierth 2008-07-28 15:20:13 Re: WITH RECUSIVE patches 0723