| From: | "myungkyu(dot)lim" <myungkyu(dot)lim(at)samsung(dot)com> |
|---|---|
| To: | "'Masahiko Sawada'" <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org>, <woosung(dot)sohn(at)samsung(dot)com>, <don(dot)hong(at)samsung(dot)com> |
| Subject: | RE: [Todo item] Add entry creation timestamp column to pg_stat_replication |
| Date: | 2018-11-15 08:02:31 |
| Message-ID: | 007701d47cb9$8f414380$adc3ca80$@samsung.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
>> I changed field name from 'reply_time' to 'last_msg_send_time'.
>> Because 'last_msg_send_time' is used in pg_stat_wal_receiver/pg_stat_subsctiption view.
>> I think that field has the same meaning.
>
>I got confused by the field name. If we have 'last_msg_send_time'
>field in pg_stat_replciation which has information of wal senders
>users would think it as a time when the wal sender sent a message last
>time. However values of the fields actually shows a time when the wal
>receiver sent a reply message last time. So perhaps
>'last_reply_send_time' would be more clear.
Good point. 'last_reply_send_time' is better.
How about just 'reply_time'?
Best regards,
Myungkyu, Lim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-15 08:14:33 | Re: Libpq support to connect to standby server as priority |
| Previous Message | Masahiko Sawada | 2018-11-15 07:04:44 | Re: FW: [Todo item] Add entry creation timestamp column to pg_stat_replication |