Re: query_planner() API change

From: "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: query_planner() API change
Date: 2013-08-05 06:23:17
Message-ID: 007301ce91a4$46050040$d20f00c0$@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Sun, Aug 4, 2013 at 6:20 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I think it's time to bite the bullet and *not* pass back completed paths.
> >> What's looking more attractive now is to just pass back the top-level
> >> RelOptInfo ("final_rel" in query_planner()).
>
> > I tend to think this is a pretty good plan.
>
> I looked around a little more and noted that this would complicate the
> special-case handling of an empty join tree (viz, "SELECT 2+2"). Right now
> query_planner() just has to make the appropriate Result path and it's done.
> We'd have to create a dummy RelOptInfo representing an empty set of relations,
> which is a bit weird but probably not too unreasonable when all's said and
done.

I think this is reasonable.

Thanks,

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2013-08-05 06:23:19 Bottlenecks with large number of relation segment files
Previous Message Amit Kapila 2013-08-05 06:14:22 Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])