From: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
---|---|
To: | "'Amit Kapila'" <amit(dot)kapila(at)huawei(dot)com>, "'Heikki Linnakangas'" <hlinnakangas(at)vmware(dot)com> |
Cc: | <pgsql-hackers(at)postgresql(dot)org>, "'Fujii Masao'" <masao(dot)fujii(at)gmail(dot)com> |
Subject: | Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown |
Date: | 2012-10-17 13:07:30 |
Message-ID: | 006c01cdac68$5dd5a070$1980e150$@kapila@huawei.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Wednesday, October 17, 2012 5:16 PM Amit Kapila wrote:
> > On Monday, October 15, 2012 3:43 PM Heikki Linnakangas wrote:
> > On 13.10.2012 19:35, Fujii Masao wrote:
> > > On Thu, Oct 11, 2012 at 11:52 PM, Heikki Linnakangas
> > > <hlinnakangas(at)vmware(dot)com> wrote:
> > >> Ok, thanks. Committed.
> > >
> > > I found one typo. The attached patch fixes that typo.
> >
> > Thanks, fixed.
> >
> > > ISTM you need to update the protocol.sgml because you added
> > > the field 'replyRequested' to WalSndrMessage and
> StandbyReplyMessage.
>
>
> >
> > > Is it worth adding the same mechanism (send back the reply
> immediately
> > > if walsender request a reply) into pg_basebackup and pg_receivexlog?
> >
> > Good catch. Yes, they should be taught about this too. I'll look into
> > doing that too.
>
> If you have not started and you don't have objection, I can pickup this
> to
> complete it.
>
> For both (pg_basebackup and pg_receivexlog), we need to get a timeout
> parameter from user in command line, as
> there is no conf file here. New Option can be -t (parameter name can be
> recvtimeout).
>
> The main changes will be in function ReceiveXlogStream(), it is a common
> function for both
> Pg_basebackup and pg_receivexlog. Handling will be done in same way as
> we
> have done in walreceiver.
Some more functions where it receives the data files also need similar
handling in pg_basebackup.
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2012-10-17 15:05:10 | Re: BUG #7584: pgadmin crash due to font change in UI |
Previous Message | Amit Kapila | 2012-10-17 11:46:04 | Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2012-10-17 13:19:58 | Re: Doc patch "only relevant" -> "relevant only" |
Previous Message | P. Christeas | 2012-10-17 12:38:41 | [PATCH] Enforce that INSERT...RETURNING preserves the order of multi rows |