| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Use appendStringInfoString and appendPQExpBufferStr where possible |
| Date: | 2020-09-28 00:47:12 |
| Message-ID: | 004654a0a2a349709b90c1494c4adb42@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Good point. There's another one:
> $ git grep -E 'appendStringInfoString.*".{,1}");'
> src/backend/utils/adt/ruleutils.c: appendStringInfoString(buf, "(");
> I noticed you added a similar thread here.
> https://commitfest.postgresql.org/30/
> I think this one could be combined as a single patchset with the existing CF entry for the other thread.
Thanks for your response, combined them as a single patchset now.
Best regards,
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Latest-appendStringInfoString-instead-of-appendStringInfo.patch | application/octet-stream | 2.2 KB |
| 0001-appendStringInfoChar-instead-of-appendStringInfoString.patch | application/octet-stream | 2.0 KB |
| 0001-Latest-appendPQExpBufferStr-instead-of-appendPQExpBuffer.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2020-09-28 00:51:03 | Re: New statistics for tuning WAL buffer size |
| Previous Message | David Rowley | 2020-09-28 00:22:29 | Planner making bad choice in alternative subplan decision |