Re: pgsql-server/src/backend catalog/index.c comma ...

From: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "'Marc G(dot) Fournier'" <scrappy(at)postgresql(dot)org>, <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql-server/src/backend catalog/index.c comma ...
Date: 2003-09-25 15:33:21
Message-ID: 002601c3837a$5af2b490$3d283ddb@PbgX
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
>
> "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp> writes:
> >> I committed the fixes a few minutes ago. I now actually
> believe that
> >> reindexing system tables works ;-) ... hopefully Hiroshi does too.
>
> > I don't see your commit message yet.
>
> CVS reports to the committers list seem to be wedged this
> afternoon :-(.
> I already complained to Marc about it. But in the meantime
> here is the
> cvs2cl entry:
>
> Remove the 'index deactivation' code, since it provides
> no useful
> protection in the shared- index case.

Seems a funny reason to me.
Well, do you also remove reltuples or relpages from pg_class ?

As I already mentioned, I don't love the ReindexProcessing global
flag from the first. For example, it's not thread-safe.

> > Is it wrong to believe I have a right to conitune the discussion ?
>
> Not at all, but I already waited two days for your response,
> and I can't
> put development on hold indefinitely.

I've spent a pretty much time only to put back your change.
What I've got until now was just a temporary neutral state.
It's not a neutral state now again. Should I be satisfied with it ?

regards,
Hiroshi Inoue

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut - PostgreSQL 2003-09-25 15:48:18 pgsql-server/src/test/regress/output constrain ...
Previous Message Peter Eisentraut - PostgreSQL 2003-09-25 06:58:07 pgsql-server/src backend/access/common/heaptup ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2003-09-25 15:36:52 Re: PL contribution guidelines?
Previous Message Shridhar Daithankar 2003-09-25 15:21:59 Re: [HACKERS] Threads vs Processes

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-09-26 00:04:08 Re: pgsql-server/src/backend catalog/index.c comma ...
Previous Message Pedro Zorzenon Neto 2003-09-24 23:11:11 Correction to 'translate' function in postgresql