Re: Hard-coded PUBLIC in pg_dump

From: "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>
To: "Nicolai Tufar" <ntufar(at)apb(dot)com(dot)tr>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hard-coded PUBLIC in pg_dump
Date: 2002-12-01 02:05:29
Message-ID: 002501c298de$201cb870$6500a8c0@internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-advocacy pgsql-general pgsql-hackers

> src/bin/pg_dump/pg_dump.c happen to have hard-coded PUBLIC role name.
> It completly breaks dumps when run with Turksh locale setting. In my
> opinion making it lower-case would do much good and no harm. A mini
> patch is given below.

Hmmmm...does putting double quotes (eg. "PUBLIC") around the public word fix
it?

> On the other hand, I was thinking about wrapping all the identifiers in
> dump files in single quotes. It is done in "SET SESSION AUTHORIZATION"
> clause. Is there a reason for not doing this with table and colum names?

You can't put single quotes around table and column names. You need to use
double quotes as they are identifiers rather than literals.

Bear in mind that some improvements have been made in Postgres 7.3 with
regards to quoting, so have you checked 7.3?

Chris

In response to

Responses

Browse pgsql-advocacy by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-12-01 02:07:35 Re: eWeek Article
Previous Message Nicolai Tufar 2002-12-01 01:45:46 Hard-coded PUBLIC in pg_dump

Browse pgsql-general by date

  From Date Subject
Next Message Nicolai Tufar 2002-12-01 02:29:27 Re: Hard-coded PUBLIC in pg_dump
Previous Message Nicolai Tufar 2002-12-01 01:45:46 Hard-coded PUBLIC in pg_dump

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-12-01 02:07:35 Re: eWeek Article
Previous Message Nicolai Tufar 2002-12-01 01:45:46 Hard-coded PUBLIC in pg_dump