newoid in invapi.c

From: "Maurice Gittens" <mgittens(at)gits(dot)nl>
To: "PostgreSQL-development" <hackers(at)postgreSQL(dot)org>
Subject: newoid in invapi.c
Date: 1998-03-06 15:30:56
Message-ID: 001c01bd4914$dbc77f20$fcf3b2c2@caleb..gits.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In the file large_object/inv_api.c there is a statement in the function
inv_create
which goes:

file_oid=newoid() + 1;

later on a heap_create_with_catalog call is performed to create a heap
for the large object called xinv<file_oid>.

According to code (and the comments in the code) the assumption is that the
oid
of the heap_relation will be equal to the value of the variable file_oid.

This of course will only be the case if nobody else called newoid()
before the heap relation is created.

This might lead the large object implementation to confuse
large object relations with other relations.

According to me this is a bug. I'm I right?

Thanks,
Maurice

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Martin 1998-03-06 16:45:15 pg_dumpall
Previous Message David Hartwig 1998-03-06 14:33:08 Re: [HACKERS] Speedups