From: | "Eugene Fokin" <elf(at)solvo(dot)ru> |
---|---|
To: | "'Ludek Finstrle'" <luf(at)pzkagis(dot)cz>, <pgsql-odbc(at)postgresql(dot)org> |
Subject: | Re: [ psqlodbc-Bugs-1000476 ] DateStyle and Transaction |
Date: | 2005-12-09 06:54:22 |
Message-ID: | 001801c5fc8d$62dfce70$dd2cc9c3@solvo.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-odbc |
Hi.
Probably, you're right about CC_commit() call place, but I think it
doesn't need to be checked about auto_commit mode. Because, after
cancellation ROLLBACK will break DateStyle either in auto_commit mode
on.
I've used auto_commit mode off only to show how manual ROLLBACK will
lose DateStyle.
Regards.
--
Eugene Fokin
SOLVO Ltd.
-----Original Message-----
From: pgsql-odbc-owner(at)postgresql(dot)org
[mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Ludek Finstrle
Sent: Friday, December 09, 2005 5:28 AM
To: pgsql-odbc(at)postgresql(dot)org
Subject: Re: [ODBC] [ psqlodbc-Bugs-1000476 ] DateStyle and Transaction
> In application, I've turned auto_commit mode off.
>
> P.S. The same thing we'll see if we cancel first select statement.
> After cancellation there will be "ROLLBACK" command which drops
> DateStyle setting too. What I think, driver should issue "COMMIT"
> right after settings in connection procedure. For example,
> call CC_commit() at the end of CC_send_settings() function.
I thinks it's better to commit later in other place
(e.g. commit set client_encoding too).
Patch attached.
Thanks for report and initial hint
Luf
From | Date | Subject | |
---|---|---|---|
Next Message | Eugene Fokin | 2005-12-09 07:24:30 | My patch for #1000475 SEGFAULT during SQLCancel |
Previous Message | Ludek Finstrle | 2005-12-09 03:14:25 | Please review this patch |