From: | "Mendola Gaetano" <mendola(at)bigfoot(dot)com> |
---|---|
To: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | SetVariable |
Date: | 2003-08-27 14:58:50 |
Message-ID: | 000b01c36cab$b9fe8b20$152aa8c0@GMENDOLA2 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
I found this code on the file variables.c and
in the function SetVariable I read:
if (strcmp(current->name, name) == 0)
{
free(current->value);
current->value = strdup(value);
return current->value ? true : false;
}
this mean that if there is no memory left on the
sistem we loose the old value,
if this is not the indeended behaviour may be is better do:
if (strcmp(current->name, name) == 0)
{
char * tmp_value = strdup(value);
if ( !tmp_value )
{
return false;
}
free(current->value);
current->value = tmp_value;
return true;
}
Regards
Gaetano Mendola
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-08-27 15:05:47 | Re: Buglist |
Previous Message | matt | 2003-08-27 14:37:14 | Re: Hardware recommendations to scale to silly load |