| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | "Baji Shaik" <baji(dot)pgdev(at)gmail(dot)com> |
| Cc: | "Chao Li" <li(dot)evan(dot)chao(at)gmail(dot)com>, "L(dot) pgsql-hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve REPACK (CONCURRENTLY) error messages for unsupported configurations |
| Date: | 2026-05-29 10:43:03 |
| Message-ID: | 00091c4d-4955-43c3-bf02-03a5b8e0f3b7@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-05-29, Baji Shaik wrote:
> LGTM, thanks for adding these.
>
> FWIW I see a couple more uncovered ereport(ERROR) paths 1/ invalid
> index (line 813) 2/ shared catalog with USING INDEX (line 580,
> needs allow_system_table_mods). But both need unusual setup, so
> fine to leave them along with the temp table one.
Yeah. I think we could still cover the one in line 580, maybe in test_decoding, but I didn't try. I'm not as excited about this one though; I'm ok to leave it as-is. Anyway, I have pushed the patch, together with moving some previous tests to test_decoding, because the error message added by your initial 0001 caused wal_level=minimal tests to fail, as shown by thorntail
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2026-05-29%2006%3A31%3A03
Thanks!
--
Álvaro Herrera
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2026-05-29 10:50:47 | Re: Key joins |
| Previous Message | Thom Brown | 2026-05-29 10:30:29 | Re: generic plans and "initial" pruning |