RE: Can't compile PG 17 (master) from git under Msys2 autoconf

From: "Regina Obe" <lr(at)pcorp(dot)us>
To: "'Alvaro Herrera'" <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "'Postgres hackers'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Can't compile PG 17 (master) from git under Msys2 autoconf
Date: 2024-04-05 17:59:26
Message-ID: 000801da8783$003cc8a0$00b659e0$@pcorp.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I think I got something not too far off from what's there now that works
> under my msys2 setup again. This is partly using your idea of using
> $(top_builddir) to qualify the path but in the LN_S section that is causing me
> grief.
> > This seems to work okay building in tree and out of tree.
> > By changing these lines in src/backend/Makefile
> >
> > $(top_builddir)/src/include/storage/lwlocknames.h:
> storage/lmgr/lwlocknames.h
> > rm -f '$@'
> > - $(LN_S) ../../backend/$< '$@'
> > + $(LN_S) $(top_builddir)/src/backend/$< '$@'
> >
> > $(top_builddir)/src/include/utils/wait_event_types.h:
> utils/activity/wait_event_types.h
> > rm -f '$@'
> > - $(LN_S) ../../backend/$< '$@'
> > + $(LN_S) $(top_builddir)/src/backend/$< '$@'
> >
> > I've also attached as a patch.
>
> Hmm, that's quite strange ... it certainly doesn't work for me. Maybe the
> LN_S utility is resolving the symlink at creation time, rather than letting it be a
> reference to be resolved later. Apparently, the only Msys2 buildfarm animal is
> now using Meson, so we don't have any representative animal for your
> situation.
>
> What does LN_S do for you anyway? Looking at
> https://stackoverflow.com/questions/61594025/symlink-in-msys2-copy-or-
> hard-link
> it sounds like this would work if the MSYS environment variable was set to
> winsymlinks (or maybe not. I don't know if a "windows shortcut" would be
> usable in this case.)
>
> --
> Álvaro Herrera PostgreSQL Developer —
> https://www.EnterpriseDB.com/
> "Nadie está tan esclavizado como el que se cree libre no siéndolo" (Goethe)

I think it ends up doing a copy thus the copy error in my log failures which don't exist anywhere in the Makefil

cp -pR ../../backend/storage/lmgr/lwlocknames.h

Sorry for not checking on a linux system. I was thinking I should have done that first.

Thanks,
Regina

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2024-04-05 18:06:50 Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs
Previous Message Melanie Plageman 2024-04-05 17:55:37 Re: Streaming read-ready sequential scan code