RE: [PATCH] Support % wildcard in extension upgrade filenames

From: "Regina Obe" <lr(at)pcorp(dot)us>
To: "'Christoph Berg'" <cb(at)df7cb(dot)de>, <pgsql-hackers(at)lists(dot)postgresql(dot)org>, <pgsql-hackers(at)postgresql(dot)org>
Cc: "'Sandro Santilli'" <strk(at)kbt(dot)io>, "'Laurenz Albe'" <laurenz(dot)albe(at)cybertec(dot)at>, "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Paul Ramsey'" <pramsey(at)cleverelephant(dot)ca>
Subject: RE: [PATCH] Support % wildcard in extension upgrade filenames
Date: 2022-11-14 04:46:50
Message-ID: 000001d8f7e4$1c840d50$558c27f0$
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> Re: Sandro Santilli
> > I'm attaching an updated version of the patch. This time the patch is
> > tested. Nothing changes unless the .control file for the subject
> > extension doesn't have a "wildcard_upgrades = true" statement.
> >
> > When wildcard upgrades are enabled, a file with a "%" symbol as the
> > "source" part of the upgrade path will match any version and
> Fwiw I believe wildcard_upgrades isn't necessary in the .control file.
> If there are no % files, none would be used anyway, and if there are, it's
> it's meant as wildcard since % won't appear in any remotely sane version
> number.
> Christoph

I also like the idea of skipping the wildcard_upgrades syntax.
Then there is no need to have a conditional control file for PG 16 vs. older


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-11-14 05:40:37 Re: Allow file inclusion in pg_hba and pg_ident files
Previous Message Bharath Rupireddy 2022-11-14 04:04:42 Re: Add test module for Custom WAL Resource Manager feature