| From: | "Takashi Menjo" <menjo(dot)takashi(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "'Peter Eisentraut'" <peter(dot)eisentraut(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | "'Heikki Linnakangas'" <hlinnaka(at)iki(dot)fi>, "'Andres Freund'" <andres(at)anarazel(dot)de>, "'Michael Paquier'" <michael(at)paquier(dot)xyz>, "'Dmitry Dolgov'" <9erthalion6(at)gmail(dot)com>, <ishizaki(dot)teruaki(at)lab(dot)ntt(dot)co(dot)jp>, <ichiyanagi(dot)yoshimi(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory |
| Date: | 2019-02-12 07:06:53 |
| Message-ID: | 000001d4c2a1$88c6cc40$9a5464c0$@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> I'm concerned with how this would affect the future maintenance of this
> code. You are introducing a whole separate code path for PMDK beside
> the normal file path (and it doesn't seem very well separated either).
> Now everyone who wants to do some surgery in the WAL code needs to take
> that into account. And everyone who wants to do performance work in the
> WAL code needs to check that the PMDK path doesn't regress. AFAICT,
> this hardware isn't very popular at the moment, so it would be very hard
> to peer review any work in this area.
Thank you for your comment. It is reasonable that you are concerned with
maintainability. Our patchset still lacks of it. I will consider about
that when I submit a next update. (It may take a long time, so please be
patient...)
Regards,
Takashi
--
Takashi Menjo - NTT Software Innovation Center
<menjo(dot)takashi(at)lab(dot)ntt(dot)co(dot)jp>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2019-02-12 07:51:41 | RE: Commit Fest 2019-01 is now closed |
| Previous Message | Haribabu Kommi | 2019-02-12 07:03:37 | pg_basebackup ignores the existing data directory permissions |