Re: Get diagnistic (row_count) 7.3 vs. 7.4 changes

From: Maksim Likharev <MLikharev(at)micropat(dot)com>
To: 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-general(at)postgresql(dot)org
Subject: Re: Get diagnistic (row_count) 7.3 vs. 7.4 changes
Date: 2004-12-03 04:59:03
Message-ID: 000001c4d8f4$cfae8f40$8815a8c0@aurigin.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On my opinion row_count should not be null due to the last operation
produced some records, copied to the temp table.

Basically it's irrelevant for me whether it fixed or not, I'll have to port
this code fast and going to use select count.

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: Wednesday, December 01, 2004 5:53 PM
> To: MLikharev(at)micropat(dot)com
> Cc: pgsql-general(at)postgresql(dot)org
> Subject: Re: [GENERAL] Get diagnistic (row_count) 7.3 vs. 7.4 changes
>
>
> Maksim Likharev <MLikharev(at)micropat(dot)com> writes:
> > consider following code:
>
> > CREATE OR REPLACE FUNCTION rowcount_test() RETURNS bigint AS '
> > DECLARE
> > base_hits bigint;
> > BEGIN
> > CREATE TEMP TABLE ltbl_temp AS SELECT 1 AS data;
> > GET DIAGNOSTICS base_hits = ROW_COUNT;
>
> > RETURN base_hits;
> > END;
> > ' LANGUAGE PLPGSQL VOLATILE;
>
> > in 7.3.3 GET DIAGNOSTICS was returning number of selected
> rows into a temp
> > table
> > in 7.4.5 GET DIAGNOSTICS returns 0
>
> Hmm. I'm not sure if that's a bug or an improvement. The command did
> not return any rows to plpgsql, so in that sense row_count = 0 is
> correct, but I can see why you feel you've lost some capability.
>
> Anyone else have an opinion about this?
>
> regards, tom lane

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Jonathan Knopp 2004-12-03 05:32:35 Is there a way to view a rewritten query?
Previous Message Michael Fuhr 2004-12-03 04:53:16 Re: psql connection timeout