| From: | Dag Lem <dag(at)nimrod(dot)no> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Run UTF8-dependent tests for citext [Re: daitch_mokotoff module] |
| Date: | 2022-01-05 11:57:21 |
| Message-ID: | ygezgoacs4e.fsf_-_@sid.nimrod.no |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Dag Lem <dag(at)nimrod(dot)no> writes:
>
>> Running "ack -l '[\x80-\xff]'" in the contrib/ directory reveals that
>> two other modules are using UTF8 characters in tests - citext and
>> unaccent.
>
> Yeah, neither of those have been upgraded to said best practice.
> (If you feel like doing the legwork to improve that situation,
> that'd be great.)
>
Please find attached a patch to run the previously commented-out
UTF8-dependent tests for citext, according to best practice. For now I
don't dare to touch the unaccent module, which seems to be UTF8-only
anyway.
Best regards
Dag Lem
| Attachment | Content-Type | Size |
|---|---|---|
| citext-utf8-tests.patch | text/x-patch | 10.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | osumi.takamichi@fujitsu.com | 2022-01-05 12:53:06 | RE: Optionally automatically disable logical replication subscriptions on error |
| Previous Message | Peter Eisentraut | 2022-01-05 11:27:33 | Re: Proposal: remove obsolete hot-standby testing infrastructure |