Re: daitch_mokotoff module

From: Dag Lem <dag(at)nimrod(dot)no>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: daitch_mokotoff module
Date: 2022-01-04 13:49:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:

> Hi,
> On 2022-01-02 21:41:53 -0500, Tom Lane wrote:
>> ... so, that test case is guaranteed to fail in non-UTF8 encodings,
>> I suppose? I wonder what the LANG environment is in that cfbot
>> instance.
> LANG="en_US.UTF-8"
> But it looks to me like the problem is in the commit cfbot creates, rather
> than the test run itself:
> Greetings,
> Andres Freund

I have now separated out the UTF8-dependent tests, hopefully according
to the current best practice (based on src/test/modules/test_regex/ and

However I guess this won't make any difference wrt. actually running the
tests, as long as there seems to be an encoding problem in the cfbot

Is there anything else I can do? Could perhaps fuzzystrmatch_utf8 simply
be commented out from the Makefile for the time being?

Best regards

Dag Lem

Attachment Content-Type Size
v5-daitch_mokotoff.patch text/x-patch 51.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-01-04 13:53:13 Re: SQL/JSON: functions
Previous Message Fabrízio de Royes Mello 2022-01-04 13:47:47 Re: Converting WAL to SQL