| From: | Dag Lem <dag(at)nimrod(dot)no> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Subject: | Re: daitch_mokotoff module |
| Date: | 2022-12-23 20:55:11 |
| Message-ID: | yge7cyhx2kw.fsf@sid.nimrod.no |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>> On 2022-Dec-22, Dag Lem wrote:
>>> This should hopefully fix the last Cfbot failures, by exclusion of
>>> daitch_mokotoff.h from headerscheck and cpluspluscheck.
>
>> Hmm, maybe it'd be better to move the typedefs to the .h file instead.
>
> Indeed, that sounds like exactly the wrong way to fix such a problem.
> The bar for excluding stuff from headerscheck needs to be very high.
>
OK, I've moved enough declarations back to the generated header file
again so as to avoid excluding it from headerscheck and cpluspluscheck.
Best regards,
Dag Lem
| Attachment | Content-Type | Size |
|---|---|---|
| v10-daitch_mokotoff.patch | text/x-patch | 39.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ted Yu | 2022-12-23 20:59:07 | Re: Making Vars outer-join aware |
| Previous Message | Dag Lem | 2022-12-23 20:34:09 | Re: daitch_mokotoff module |