Re: Event Triggers reduced, v1

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers reduced, v1
Date: 2012-07-12 12:50:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> All done in the attached. As usual, you get an incremental patch and a
> complete one. It's also published on github for easy browsing:

Same as usual, even if that's a very little adjustment this time:

>> any rate having NameData involved seems like it's probably not too
>> good an idea; if for some reason we need to keep that hash, use a
>> NUL-terminated string and initialize the hash table with string_hash
>> instead of tag_hash. That'll be simpler and also allows the length of
>> the buffer to vary independently of NAMEDATALEN, which can only be to
>> the good.

Fixed now, using a char[] as with PortalHashTable for example.

Dimitri Fontaine PostgreSQL : Expertise, Formation et Support

Attachment Content-Type Size
event_triggers_v1.10.patch.gz application/octet-stream 48.7 KB
event_triggers_v1.9--v1.10.patch text/x-patch 2.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2012-07-12 13:05:51 Re: Synchronous Standalone Master Redoux
Previous Message Kohei KaiGai 2012-07-12 11:48:20 Re: pgsql_fdw in contrib