From: | Gunnar Rønning <gunnar(at)polygnosis(dot)com> |
---|---|
To: | <Dave(at)micro-automation(dot)net> |
Cc: | "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "'Barry Lind'" <barry(at)xythos(dot)com>, "'PostgreSQL jdbc list'" <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: RE: [ADMIN] High memory usage [PATCH] |
Date: | 2001-06-26 13:24:07 |
Message-ID: | m2sngnbci0.fsf@smaug.polygnosis.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-admin pgsql-jdbc pgsql-patches |
* "Dave Cramer" <Dave(at)micro-automation(dot)net> wrote:
|
| Bruce, Barry,
|
| How about checking for the existence of the date object in the
| constructor? This would mean that it would only be created once per
| thread.
|
I only briefly reviewd the code in PreparedStatement yeaterday with respect
to the usage of the SimpleDateFormat, my comments :
- Why the ThreadLocal usage, and not just syncronize on the same
SimpleDateFormat ?
- It seems to that the SimpleDateFormat is never modified after creation.
Wouldn't this mean that we actually could assign the SimpleDateFormat
object to a static member, so we only had to create the object once.
Or is concurrent usage of SimpleDateFormat.format() unsafe ?
I would prefer the latter if safe, as we would get less object creation and
synchronization.
regards,
Gunnar
--
Gunnar Rønning - gunnar(at)polygnosis(dot)com
Senior Consultant, Polygnosis AS, http://www.polygnosis.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Stephenson | 2001-06-26 13:37:09 | Re: RE: [ADMIN] High memory usage [PATCH] |
Previous Message | Dave Cramer | 2001-06-26 12:29:20 | High Memory Usage Patch -- Disregard my last message |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Stephenson | 2001-06-26 13:37:09 | Re: RE: [ADMIN] High memory usage [PATCH] |
Previous Message | Dave Cramer | 2001-06-26 12:29:20 | High Memory Usage Patch -- Disregard my last message |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Stephenson | 2001-06-26 13:37:09 | Re: RE: [ADMIN] High memory usage [PATCH] |
Previous Message | Dave Cramer | 2001-06-26 12:29:20 | High Memory Usage Patch -- Disregard my last message |