Re: Extensions, this time with a patch

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-11-23 09:19:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> the handling of relative vs absolute paths is bogus here. I think it'd
> make more sense to have a bool "are we including"; and if that's false and
> the path is not absolute, then the file is relative to CWD; or maybe we
> make it absolute by prepending PGDATA; maybe something else? (need to
> think of something that makes sense for both recovery.conf and extension
> control files)

Current coding in extensions prepend any control or script file with
sharepath, so that we're only dealing with absolute filename here. The
idea is that it's no business for any other part of the code to have to
know where we decide to install control and script files.

My feeling is that when !is_absolute_path(config_file) and calling_file
is NULL we should make the config_file absolute by prepending PGDATA.
Please find that done in attached v4 of the cfparser patch.

>> If that looks ok, do we want to add some documentation about the new
>> lexer capabilities?
> beyond extra code comments? probably not.


>> Also, for what good reason would we want to prevent
>> people from using the include facility?
> Not sure about this

Ok, nothing special here.
Dimitri Fontaine PostgreSQL : Expertise, Formation et Support

Attachment Content-Type Size
cfparser.v4.patch text/x-patch 17.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Shigeru HANADA 2010-11-23 10:09:20 Re: SQL/MED estimated time of arrival?
Previous Message Heikki Linnakangas 2010-11-23 08:42:13 Re: visibility map