From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
---|---|
To: | masao(dot)fujii(at)oss(dot)nttdata(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, gkokolatos(at)protonmail(dot)com, kasahara(dot)tatsuhito(at)gmail(dot)com, craig(at)2ndquadrant(dot)com |
Subject: | Re: Get memory contexts of an arbitrary backend process |
Date: | 2021-03-29 02:59:13 |
Message-ID: | fd78be66959cbf3957a329bb069ab737@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021-03-26 14:08, Kyotaro Horiguchi wrote:
> At Fri, 26 Mar 2021 14:02:49 +0900, Fujii Masao
> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>>
>>
>> On 2021/03/26 13:28, Kyotaro Horiguchi wrote:
>> >> "some contexts are omitted"
>> >> "n child contexts: total_bytes = ..."
>> > Sorry I missed that is already implemented. So my opnion is I agree
>> > with limiting with a fixed-number, and preferablly sorted in
>> > descending order of... totalspace/nblocks?
>>
>> This may be an improvement, but makes us modify
>> MemoryContextStatsInternal()
>> very much. I'm afraid that it's too late to do that at this stage...
>> What about leaving the output order as it is at the first version?
>
> So I said "preferably":p (with a misspelling...)
> I'm fine with that.
>
> regards.
Thanks for the comments!
Attached a new patch.
It adds pg_log_backend_memory_contexts(pid) which logs memory contexts
of the specified backend process.
The number of child contexts to be logged per parent is limited to 100
as with MemoryContextStats().
As written in commit 7b5ef8f2d07, which limits the verbosity of
memory context statistics dumps, it supposes that practical cases
where the dump gets long will typically be huge numbers of
siblings under the same parent context; while the additional
debugging value from seeing details about individual siblings
beyond 100 will not be large.
Thoughts?
Regards.
Attachment | Content-Type | Size |
---|---|---|
v5-0001-add-memorycontext-elog-print.patch | text/x-diff | 24.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Zhihong Yu | 2021-03-29 02:59:43 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |
Previous Message | David Rowley | 2021-03-29 02:20:36 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |