Re: pg_upgrade fails with non-standard ACL

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Arthur Zakirov <zaartur(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2021-01-21 15:42:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 21.01.2021 07:07, Noah Misch wrote:
>> On Thu, Jun 11, 2020 at 07:58:43PM +0300, Anastasia Lubennikova wrote:
>> Thank you for the review.
>> New version of the patch is attached, though I haven't tested it properly
>> yet. I am planning to do in a couple of days.
> Once that testing completes, please change the commitfest entry status to
> Ready for Committer.
New version is attached along with a test script.

To use it, you can simply run script in a
directory that contains postrges git repository. See comments in the file.

The test includes patch to rename several system objects.

Renamed objects are the following:
- table pg_subscription -> pg_sub
- columns pg_subscription.subenabled -> subactive,
- view pg_stat_subscription -> pg_stat_sub
pg_stat_subscription.latest_end_lsn -> latest_end_location
- function pg_stat_get_subscription -> pg_stat_get_sub
- language sql -> pgsql

Compared to v11, I fixed a couple of minor issues and removed language
It seems unlikely, that we will ever change language signature, which
consist of language name only.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
pg_upgrade_ACL_check_v12.patch text/x-patch 14.8 KB application/x-shellscript 3.1 KB
test_add_acl_to_catalog_objects.sql application/sql 597 bytes
test_rename_catalog_objects_v12 text/plain 352.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-01-21 16:17:40 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Fujii Masao 2021-01-21 15:28:05 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit