| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add const qualifiers |
| Date: | 2023-09-26 20:19:12 |
| Message-ID: | fa3bef59-2202-a61d-c4d9-72e419bfe5f3@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/26/23 06:34, Peter Eisentraut wrote:
> On 09.09.23 21:03, David Steele wrote:
>> On 9/1/23 11:39, David Steele wrote:
>>> Hackers,
>>>
>>> I noticed that there was a mismatch between the const qualifiers for
>>> excludeDirContents in src/backend/backup/backup/basebackup.c and
>>> src/bin/pg_rewind/file_map.c and that led me to use ^static
>>> const.*\*.*= to do a quick search for similar cases.
>>>
>>> I think at the least we should make excludeDirContents match, but the
>>> rest of the changes seem like a good idea as well.
>>
>> Added to 2023-11 CF.
>
> committed
Thank you, Peter!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-09-26 21:07:45 | Re: Obsolete reference to pg_relation in comment |
| Previous Message | Jeff Davis | 2023-09-26 19:32:13 | Re: Is this a problem in GenericXLogFinish()? |