| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Carlos Alves <carlos(at)alves(dot)inf(dot)br>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: COMMENTS are not being copied in CREATE TABLE LIKE |
| Date: | 2026-03-26 18:12:04 |
| Message-ID: | f9d90b0b-d57c-4887-968b-31b399d05942@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Carlos
On 26/03/2026 18:59, Carlos Alves wrote:
> No errors or failures were detected during the tests.
>
> The only suggestion is to keep the parameter description a single paragraph, following the same style as the description of the other inclusion parameters. But the current description is coherent and okay.
>
> After the tests, the patch is working as expected:
> - Table-level comments are copied when the `including comments` parameter is used.
> - When there is more than one source table, comments, if any, are kept in the order in which they appear in the command, separated by a new line.
> - The performance of command execution was not affected.
>
> I think only the code review is missing, but I don't have much experience to perform this step.
Thanks for this thorough review. This helps a lot!
Let's see what the other reviewers have to say about the code and your
docs suggestion.
Best, Jim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2026-03-26 18:12:14 | Re: Use correct collation in pg_trgm |
| Previous Message | Carlos Alves | 2026-03-26 17:59:44 | Re: COMMENTS are not being copied in CREATE TABLE LIKE |