Remove IndexInfo.ii_OpclassOptions field

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Remove IndexInfo.ii_OpclassOptions field
Date: 2023-08-24 06:57:58
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

During some refactoring I noticed that the field
IndexInfo.ii_OpclassOptions is kind of useless. The IndexInfo struct is
notionally an executor support node, but this field is not used in the
executor or by the index AM code. It is really just used in DDL code in
index.c and indexcmds.c to pass information around locally. For that,
it would be clearer to just use local variables, like for other similar
cases. With that change, we can also remove
RelationGetIndexRawAttOptions(), which only had one caller left, for
which it was overkill.

Attachment Content-Type Size
0001-Remove-IndexInfo.ii_OpclassOptions-field.patch text/plain 10.6 KB
0002-Remove-unused-include.patch text/plain 728 bytes
0003-Remove-RelationGetIndexRawAttOptions.patch text/plain 3.0 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-08-24 07:50:44 Re: subscription/015_stream sometimes breaks
Previous Message Andres Freund 2023-08-24 06:25:47 Re: meson uses stale pg_config_paths.h left over from make