| From: | Manfred Koizar <mkoi-pg(at)aon(dot)at> | 
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org | 
| Subject: | More vacuum.c refactoring | 
| Date: | 2004-06-10 20:08:22 | 
| Message-ID: | f5fhc09r8a5if2iodf0m72shi5m7j62cn3@email.aon.at | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Near the end of repair_frag() in vacuum.c -- under the comment /* clean
moved tuples from last page in Nvacpagelist list */ -- there is code
that marks itemids as unused.  Itemids affected are those referring to
tuples that have been moved off the last page.
This code is very similar to vacuum_page().  The major difference is
that vacuum_page() uses vacpage->offsets while the code in repair_frag()
looks for MOVED_OFF bits in tuple headers.  AFAICS the tuples with the
MOVED_OFF bit set are exactly those referenced by vacpage->offsets.
The attached patch passes make check and make installcheck.  Please
apply unless I'm missing something.
Servus
 Manfred
| Attachment | Content-Type | Size | 
|---|---|---|
| unknown_filename | text/plain | 2.2 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-06-10 20:09:30 | Re: Nested xacts: looking for testers and review | 
| Previous Message | Alvaro Herrera | 2004-06-10 20:05:13 | Re: Nested xacts: looking for testers and review |