Re: Improve error handling of HMAC computations and SCRAM

From: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improve error handling of HMAC computations and SCRAM
Date: 2022-01-13 08:26:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 13.01.2022 10:24, Michael Paquier wrote:
> Thanks for the review. The comments about pg_hmac_ctx->data were
> wrong from the beginning, coming, I guess, from one of the earlier
> patch versions where this was discussed. So I have applied that
> independently.
> I have also spent a good amount of time on that to close the loop and
> make sure that no code paths are missing an error context, adjusted a
> couple of comments to explain more the role of *errstr in all the
> SCRAM routines, and finally applied it on HEAD.

Sergey Shinderuk

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-01-13 08:39:42 Re: ICU for global collation
Previous Message Michael Paquier 2022-01-13 07:30:23 Re: 2022-01 Commitfest