On 13.01.2022 10:24, Michael Paquier wrote: > Thanks for the review. The comments about pg_hmac_ctx->data were > wrong from the beginning, coming, I guess, from one of the earlier > patch versions where this was discussed. So I have applied that > independently. > > I have also spent a good amount of time on that to close the loop and > make sure that no code paths are missing an error context, adjusted a > couple of comments to explain more the role of *errstr in all the > SCRAM routines, and finally applied it on HEAD. Thanks!